Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage check #1123

Merged
merged 6 commits into from
May 5, 2024
Merged

Coverage check #1123

merged 6 commits into from
May 5, 2024

Conversation

jknndy
Copy link
Collaborator

@jknndy jknndy commented May 5, 2024 •
edited
Loading

Expands test coverage for 304 sites. Generated with the help of a new test that i'll open in a new PR after some clean up for discussion.

Scraper Changes

  • Split the total_time function into prep_time, cook_time and total_time& adjusted to return None if not present in joshuaweissman
  • Set usapears to return null on ratings to avoid error.

cc. @mlduff

@jknndy jknndy marked this pull request as ready for review May 5, 2024 23:02
@jknndy jknndy merged commit b4567bf into hhursev:main May 5, 2024
18 checks passed
@jknndy jknndy mentioned this pull request May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jknndy