v14: backport a few scraper fixes/adjustments from v15 branch. #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
force-pushed
the
backporting/v15-scraper-fixups
branch
from
45b4159 to
b0ea4b9
Compare
|
Converting to draft while considering whether raising an exception is the best course of action for fields that are not expected to be possible to extract from a particular website. |
jayaddison
force-pushed
the
backporting/v15-scraper-fixups
branch
from
5820cf4 to
6ea883a
Compare
|
Generally I think the preferable approach is to emit warnings -- but continue to return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous small scraper adjustments/fixups from
v15that I think may be worthwhile to apply to the current mainline /v14series.This should also make the comparison diff between the next
v14andv15release easier to review (both for us and anyone considering using or redistributingv15releases).