From ea3ccd315297cbd2a410471d4f1aed51a0281064 Mon Sep 17 00:00:00 2001 From: Gaetan Date: Wed, 16 Jun 2021 08:48:01 +0200 Subject: [PATCH 1/4] fix(provider): remove view loading --- src/Providers/PackageServiceProvider.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/Providers/PackageServiceProvider.php b/src/Providers/PackageServiceProvider.php index 9fd0fe1..9115442 100644 --- a/src/Providers/PackageServiceProvider.php +++ b/src/Providers/PackageServiceProvider.php @@ -11,7 +11,7 @@ class PackageServiceProvider extends ServiceProvider /** * Our root directory for this package to make traversal easier. */ - public const PACKAGE_DIR = __DIR__.'/../../'; + public const PACKAGE_DIR = __DIR__ . '/../../'; /** * Name for this package to publish assets. @@ -23,8 +23,6 @@ class PackageServiceProvider extends ServiceProvider */ public function boot() { - $this->loadViewsFrom($this->getPath('resources/views'), $this->getNormalizedNamespace()); - $this->strapPublishers(); } @@ -48,7 +46,7 @@ protected function getPath($path = '') // We get the child class $rc = new ReflectionClass(get_class($this)); - return dirname($rc->getFileName()).'/../../'.$path; + return dirname($rc->getFileName()) . '/../../' . $path; } /** @@ -82,7 +80,7 @@ protected function strapPublishers(): void $configPath = $this->getPath('config'); $this->publishes([ - "{$configPath}/config.php" => config_path($this->getNormalizedNamespace().'.php'), - ], $this->getNormalizedNamespace().'-config'); + "{$configPath}/config.php" => config_path($this->getNormalizedNamespace() . '.php'), + ], $this->getNormalizedNamespace() . '-config'); } } From 33f992db50151e074a1d679a43897aae79afe644 Mon Sep 17 00:00:00 2001 From: gaetan-hexadog Date: Wed, 16 Jun 2021 11:03:24 +0000 Subject: [PATCH 2/4] Automatically applied php-cs-fixer changes --- src/Providers/PackageServiceProvider.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Providers/PackageServiceProvider.php b/src/Providers/PackageServiceProvider.php index 9115442..b8f44b8 100644 --- a/src/Providers/PackageServiceProvider.php +++ b/src/Providers/PackageServiceProvider.php @@ -11,7 +11,7 @@ class PackageServiceProvider extends ServiceProvider /** * Our root directory for this package to make traversal easier. */ - public const PACKAGE_DIR = __DIR__ . '/../../'; + public const PACKAGE_DIR = __DIR__.'/../../'; /** * Name for this package to publish assets. @@ -46,7 +46,7 @@ protected function getPath($path = '') // We get the child class $rc = new ReflectionClass(get_class($this)); - return dirname($rc->getFileName()) . '/../../' . $path; + return dirname($rc->getFileName()).'/../../'.$path; } /** @@ -80,7 +80,7 @@ protected function strapPublishers(): void $configPath = $this->getPath('config'); $this->publishes([ - "{$configPath}/config.php" => config_path($this->getNormalizedNamespace() . '.php'), - ], $this->getNormalizedNamespace() . '-config'); + "{$configPath}/config.php" => config_path($this->getNormalizedNamespace().'.php'), + ], $this->getNormalizedNamespace().'-config'); } } From 75841c66b62080c5d1d9645bac8fc63c9bc245f4 Mon Sep 17 00:00:00 2001 From: Gaetan Date: Wed, 16 Jun 2021 13:11:27 +0200 Subject: [PATCH 3/4] chore(style): update php-cs-fixer config --- .php-cs-fixer.dist.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php index 7e419e9..d46f825 100644 --- a/.php-cs-fixer.dist.php +++ b/.php-cs-fixer.dist.php @@ -20,5 +20,8 @@ ->setRules([ '@PSR2' => true, '@PhpCsFixer' => true, + 'concat_space' => [ + 'spacing' => 'one' + ] ]) ->setFinder($finder); From 24e4c8b24d4cae9ee59eb996e89884fd1045e839 Mon Sep 17 00:00:00 2001 From: gaetan-hexadog Date: Wed, 16 Jun 2021 11:11:49 +0000 Subject: [PATCH 4/4] Automatically applied php-cs-fixer changes --- src/Providers/PackageServiceProvider.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Providers/PackageServiceProvider.php b/src/Providers/PackageServiceProvider.php index b8f44b8..9115442 100644 --- a/src/Providers/PackageServiceProvider.php +++ b/src/Providers/PackageServiceProvider.php @@ -11,7 +11,7 @@ class PackageServiceProvider extends ServiceProvider /** * Our root directory for this package to make traversal easier. */ - public const PACKAGE_DIR = __DIR__.'/../../'; + public const PACKAGE_DIR = __DIR__ . '/../../'; /** * Name for this package to publish assets. @@ -46,7 +46,7 @@ protected function getPath($path = '') // We get the child class $rc = new ReflectionClass(get_class($this)); - return dirname($rc->getFileName()).'/../../'.$path; + return dirname($rc->getFileName()) . '/../../' . $path; } /** @@ -80,7 +80,7 @@ protected function strapPublishers(): void $configPath = $this->getPath('config'); $this->publishes([ - "{$configPath}/config.php" => config_path($this->getNormalizedNamespace().'.php'), - ], $this->getNormalizedNamespace().'-config'); + "{$configPath}/config.php" => config_path($this->getNormalizedNamespace() . '.php'), + ], $this->getNormalizedNamespace() . '-config'); } }