Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(robot): forward InternalIPs by default on Robot nodes #865

Merged
merged 16 commits into from
Mar 4, 2025

Conversation

lukasmetzner
Copy link
Contributor

@lukasmetzner lukasmetzner commented Feb 10, 2025

Whenever a user configures the --node-ip flag, we forward the configured IPs. We validate if the IP already exists as an ExternalIP and does not collide with the configured address family. This improves the Robot support for HCCM, as users can configure private IPs for Robot nodes.

Forwarding only happens during the initialization phase of HCCM and should therefore not break existing clusters.

This feature can be disabled by setting the environment variable ROBOT_FORWARD_INTERNAL_IPS to false.

Co-authored-by: Alexander Block ablock84@gmail.com

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 70.59%. Comparing base (427ea35) to head (81c5c43).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/instances.go 81.81% 5 Missing and 3 partials ⚠️
internal/config/config.go 40.00% 2 Missing and 1 partial ⚠️
hcloud/instances_util.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
- Coverage   70.69%   70.59%   -0.10%     
==========================================
  Files          31       31              
  Lines        3310     3343      +33     
==========================================
+ Hits         2340     2360      +20     
- Misses        795      804       +9     
- Partials      175      179       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukasmetzner lukasmetzner changed the title feat(robot): forward InternalIPs by default on Robot nodes. feat(robot): forward InternalIPs by default on Robot nodes Feb 12, 2025
@lukasmetzner lukasmetzner marked this pull request as draft February 12, 2025 17:56
@lukasmetzner lukasmetzner marked this pull request as ready for review February 13, 2025 08:36
@lukasmetzner lukasmetzner force-pushed the robot-vswitch-forward-internal-ips branch from 83224aa to 06fe7e0 Compare February 25, 2025 07:22
Whenever a user configures the `--node-ip` flag, we forward the configured IPs without validating them. This should improve Robot support for HCCM, as users now can configure private IPs for Robot nodes, like for example vSwitch IPs.

This forwarding only happens during the initialization phase of HCCM and should therefore not break existing clusters.
Renamed ROBOT_DISABLE_FORWARD_INTERNAL_IPS -> ROBOT_FORWARD_INTERNAL_IPS
@lukasmetzner lukasmetzner force-pushed the robot-vswitch-forward-internal-ips branch from d7d6345 to 16b6a85 Compare March 4, 2025 08:46
Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
@lukasmetzner lukasmetzner merged commit 7b97ce2 into main Mar 4, 2025
9 checks passed
@lukasmetzner lukasmetzner deleted the robot-vswitch-forward-internal-ips branch March 4, 2025 13:27
@lukasmetzner lukasmetzner linked an issue Mar 4, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants