-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(robot): forward InternalIPs by default on Robot nodes #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
- Coverage 70.69% 70.59% -0.10%
==========================================
Files 31 31
Lines 3310 3343 +33
==========================================
+ Hits 2340 2360 +20
- Misses 795 804 +9
- Partials 175 179 +4 ☔ View full report in Codecov by Sentry. |
apricote
reviewed
Feb 10, 2025
83224aa
to
06fe7e0
Compare
Whenever a user configures the `--node-ip` flag, we forward the configured IPs without validating them. This should improve Robot support for HCCM, as users now can configure private IPs for Robot nodes, like for example vSwitch IPs. This forwarding only happens during the initialization phase of HCCM and should therefore not break existing clusters.
Renamed ROBOT_DISABLE_FORWARD_INTERNAL_IPS -> ROBOT_FORWARD_INTERNAL_IPS
d7d6345
to
16b6a85
Compare
apricote
requested changes
Mar 4, 2025
Co-authored-by: Julian Tölle <julian.toelle@hetzner-cloud.de>
apricote
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a user configures the
--node-ip
flag, we forward the configured IPs. We validate if the IP already exists as an ExternalIP and does not collide with the configured address family. This improves the Robot support for HCCM, as users can configure private IPs for Robot nodes.Forwarding only happens during the initialization phase of HCCM and should therefore not break existing clusters.
This feature can be disabled by setting the environment variable
ROBOT_FORWARD_INTERNAL_IPS
tofalse
.Co-authored-by: Alexander Block ablock84@gmail.com