feat(load-balancer): emit warning if unsupported port protocol is configured #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a check to ensure that only supported network protocols are configured. Notably UDP is not supported by the Hetzner Cloud load balancer. Dispatching an event is not necessary here, as this automatically happens when returning an error in the `EnsureLoadBalancer` call.
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 70.56% 70.68% +0.12%
==========================================
Files 31 31
Lines 3285 3299 +14
==========================================
+ Hits 2318 2332 +14
Misses 793 793
Partials 174 174 ☔ View full report in Codecov by Sentry. |
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
|
If I understand this, we only trigger a warning event, and we don't fail? |
jooola
reviewed
Dec 19, 2024
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
jooola
reviewed
Dec 20, 2024
jooola
approved these changes
Dec 20, 2024
Yes. I still need to update the unit test |
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
lukasmetzner
changed the title
lukasmetzner
deleted the
799-validate-protocol-support-for-ports-on-load-balancers
branch
lukasmetzner
pushed a commit
that referenced
this pull request
Jan 10, 2025
<!-- section-start changelog --> This release includes an extension of our current metrics to also include the internals of `k8s.io/cloud-provider` with respect to the work queue depth and requests to the Kubernetes API. Besides having all data available, this will also help us with debugging [#661](#661). ### Features - **metrics**: add metrics from cloud-provider library (#824) - **load-balancer**: emit warning if unsupported port protocol is configured (#828) - allow arbitrary length API tokens (#752) <!-- section-end changelog --> --- <details> <summary><h4>PR by <a href="https://github.com/apricote/releaser-pleaser">releaser-pleaser</a> 🤖</h4></summary> If you want to modify the proposed release, add you overrides here. You can learn more about the options in the docs. ## Release Notes ### Prefix / Start This will be added to the start of the release notes. ```rp-prefix This release includes an extension of our current metrics to also include the internals of `k8s.io/cloud-provider` with respect to the work queue depth and requests to the Kubernetes API. Besides having all data available, this will also help us with debugging [#661](#661). ``` ### Suffix / End This will be added to the end of the release notes. ```rp-suffix ``` </details> Co-authored-by: releaser-pleaser <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an unsupported port protocol is configured a warning event and log message is emitted.