Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixed outdated version policy #815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lukasmetzner
Copy link
Contributor

@lukasmetzner lukasmetzner commented Dec 18, 2024

Version policy got oudated over time. Switching to latest instead of vX.X.X+ as its less effort and consistent with other products.

@lukasmetzner lukasmetzner requested a review from a team as a code owner December 18, 2024 09:37
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32.38%. Comparing base (d0eba3e) to head (1caf35d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #815      +/-   ##
==========================================
- Coverage   35.34%   32.38%   -2.97%     
==========================================
  Files          20       21       +1     
  Lines        1901     2075     +174     
==========================================
  Hits          672      672              
- Misses       1195     1369     +174     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 287 to 289
| 1.31 | latest | https://raw.githubusercontent.com/hetznercloud/csi-driver/v2.9.0/deploy/kubernetes/hcloud-csi.yml |
| 1.30 | latest | https://raw.githubusercontent.com/hetznercloud/csi-driver/v2.9.0/deploy/kubernetes/hcloud-csi.yml |
| 1.29 | latest | https://raw.githubusercontent.com/hetznercloud/csi-driver/v2.9.0/deploy/kubernetes/hcloud-csi.yml |
Copy link
Member

@apricote apricote Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the URL to point to the latest release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized we don't actually have the hcloud-csi.yml in the releases. Shall I maybe put v2.11.0+ there and create a new Issue/PR for adding hcloud-csi.yml to the release artifacts + updating doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants