fix(metrics): not report status code 200 when http client returns error #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CoderPoet
reviewed
Mar 14, 2024
@2011aad CLA 需要处理下哈 |
…nd no response received
2011aad
force-pushed
the
feature/fix-report-status-code-on-error
branch
from
fb5258a to
06d4920
Compare
|
ci 的 lint 需要修下 |
rogerogers
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix(metrics): do not report status code 200 when http client returns error
What this PR does / why we need it (English/Chinese):
en: Currently, http client report metrics status code as 200 when client returns an error.
zh: 当前在http客户端返回错误时，metrics上报的status code是200。
Which issue(s) this PR fixes: