feat: use app.GetHandlerName replace of reflect value #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGYFFFF
reviewed
Feb 2, 2024
FGYFFFF
approved these changes
Feb 2, 2024
li-jin-gou
reviewed
Feb 2, 2024
rogerogers
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does / why we need it (English/Chinese):
hertz支持使用 SetHandlerName解决使用匿名函数注册路由时 handlerName为func1的问题，但是telemetry在构建span获取handler名称的时候 使用 反射获取方法名的方式，导致handlerName始终为func1影响trace注入。
使用hertz提供的app.GetHandlerName 替换HandleName()，解决无法获取到handlerName的问题。
Which issue(s) this PR fixes:
无