Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add provider delay config for app delete #158

Closed
wants to merge 2 commits into from

Conversation

talbright
Copy link
Contributor

@talbright talbright commented Dec 16, 2018

This is a continuation of #142 to add an additional post_app_delete_delay to address #123.

provider "heroku" {
  "delays"  {
     post_app_delete_delay = 10  
  }
}

@ghost ghost added the size/XS label Dec 16, 2018
@talbright talbright changed the title add provider delay config for space delete add provider delay config for app delete Dec 16, 2018
@talbright talbright force-pushed the post-space-delete-delay branch from 04d2048 to 7ad2a38 Compare December 16, 2018 22:32
Copy link
Member

@mars mars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Looks great!

Only the CHANGELOG will need to be updated from master.

@talbright
Copy link
Contributor Author

I still haven't been able to recreate the issue. Probably I need to create real dynos instead of just the apps per #159 . Might be a good chance to give the fancy new build resource a try.

@ghost ghost added size/S and removed size/XS labels Dec 21, 2018
@talbright
Copy link
Contributor Author

talbright commented Mar 26, 2019

Looks like I forgot to come back to this! I was never able to reproduce the issue, do you think we should close this or put it in anyways since it was reported in #123? @mars

@talbright
Copy link
Contributor Author

I'll close this for now, if it comes up again we can raise it back from the 💀

@talbright talbright closed this Mar 27, 2019
@mars
Copy link
Member

mars commented Mar 27, 2019

I've Terraform destroyed a Space with apps in it sooo many times, never encountered an eventual consistency issue on app delete. I wonder if the initial bug reported was a manifestation of some underlying Private Spaces behavior or bug that has since been changed. ANyway. Thanks for cleaning this up @talbright !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants