Mcpods 6515 update apis #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6515-update--new # Conflicts: # here-naksha-app-service/src/test/java/com/here/naksha/app/service/NakshaAppTest.java
hirenkp2000
requested changes
Nov 21, 2023
here-naksha-app-service/src/test/java/com/here/naksha/app/service/NakshaAppTest.java
Show resolved
Hide resolved
...pp-service/src/test/resources/unit_test_data/TC0500_updateFeatures/response_no_geometry.json
Show resolved
Hide resolved
here-naksha-app-service/src/test/java/com/here/naksha/app/service/NakshaAppTest.java
Show resolved
Hide resolved
here-naksha-lib-core/src/main/java/com/here/naksha/lib/core/util/storage/RequestHelper.java
Outdated
Show resolved
Hide resolved
…tToXyzCollectionResponse
Amaneusz
approved these changes
Nov 24, 2023
...ha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/WriteFeatureApiTask.java
Outdated
Show resolved
Hide resolved
...ha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/WriteFeatureApiTask.java
Outdated
Show resolved
Hide resolved
here-naksha-app-service/src/test/java/com/here/naksha/app/service/UpdateFeatureTestHelper.java
Outdated
Show resolved
Hide resolved
hirenkp2000
requested changes
Nov 24, 2023
...ha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/WriteFeatureApiTask.java
Outdated
Show resolved
Hide resolved
...ha-app-service/src/main/java/com/here/naksha/app/service/http/tasks/WriteFeatureApiTask.java
Outdated
Show resolved
Hide resolved
here-naksha-app-service/src/main/resources/swagger/openapi.yaml
Outdated
Show resolved
Hide resolved
here-naksha-app-service/src/test/java/com/here/naksha/app/service/UpdateFeatureTestHelper.java
Show resolved
Hide resolved
here-naksha-app-service/src/test/java/com/here/naksha/app/service/UpdateFeatureTestHelper.java
Outdated
Show resolved
Hide resolved
here-naksha-app-service/src/test/java/com/here/naksha/app/service/UpdateFeatureTestHelper.java
Show resolved
Hide resolved
here-naksha-lib-core/src/main/java/com/here/naksha/lib/core/util/storage/RequestHelper.java
Outdated
Show resolved
Hide resolved
…6515-update--new # Conflicts: # here-naksha-lib-core/src/main/java/com/here/naksha/lib/core/util/storage/ResultHelper.java # here-naksha-lib-hub/src/main/java/com/here/naksha/lib/hub/mock/MockWriteResult.java
hirenkp2000
approved these changes
Nov 28, 2023
here-naksha-app-service/src/main/resources/swagger/openapi.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@Amaneusz - is it right to assume that we can now support geometry verification in the API responses? Or it still requires some more alignment?
If support already available, then @gunplar I recommend we start adding geometry based verification again in the API responses. If not, then we can just create a ticket for now and can pick it up again soon.
Either ways, this PR can still go ahead as long as other comments are addressed. Geometry verification can be picked up as separate item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.