Support multiple JWT keys #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
Files
|
Code Coverage
Files
|
Code Coverage
Files
|
Code Coverage
Files
|
Code Coverage
Files
|
Code Coverage
Files
|
gunplar
reviewed
Jan 2, 2025
docker/README.md
Outdated
| --env NAKSHA_JWT_PVT_KEY=<your naksha JWT private key with '\n' for new lines> \ | ||
| --env NAKSHA_JWT_PUB_KEY=<your naksha JWT public key with '\n' for new lines> \ | ||
| --env NAKSHA_CONFIG_ID="<your Naksha config id>" \ | ||
| --env NAKSHA_ADMIN_DB_URL="<your DB uri that Naksha should use>" \ |
There was a problem hiding this comment.
I feel it might be better to leave out the double quotes for any beginners of shell scripting, then the errors will give hint, and they should supply their own inputs. That is easier to learn, rather than searching docker log for the eventual errors from dummy settings.
There was a problem hiding this comment.
Ok, reverted the changes
Code Coverage
Files
|
gunplar
reviewed
Jan 3, 2025
| @@ -1,11 +1,13 @@ | |||
| { | |||
| "id": "cloud-config", | |||
| "type": "Config", | |||
| "type": "Feature", | |||
There was a problem hiding this comment.
Does this affect (de)serialization in any way, considering the annotation in NakshaHubConfig @JsonTypeName(value = "Config") still in v2?
There was a problem hiding this comment.
Yes. Earlier it was a problem. Now, it won't be as the said annotation is removed, allowing it to use "Feature" as standard type.
There was a problem hiding this comment.
Ah excuse me, it was at the end of the files changed list.
Code Coverage
Files
|
gunplar
reviewed
Jan 3, 2025
HERE_NOTICE
Outdated
| @@ -7,7 +7,7 @@ The applicable license information is listed below: | |||
| ---- | |||
| (c) 2014-2023 Denis Pushkarev | |||
| Copyright (c) 2017 $YEAR HERE Europe B.V. | |||
| Copyright (c) 2017-2024 HERE Europe B.V. | |||
| Copyright (c) 2017-2025 HERE Europe B.V. | |||
gunplar
approved these changes
Jan 3, 2025
Code Coverage
Files
|
rlakde
added a commit
that referenced
this pull request
Jan 3, 2025
* Updated doc about existing JWT loading * added support for additional pub key * updated readme * Updated version to 2.2.1 * Updated doc for pvt and pub key * Added constants in NakshaHubConfig constructor * addressed review comments Co-authored-by: Hiren Patel <80465571+hirenkp2000@users.noreply.github.com>
rlakde
added a commit
that referenced
this pull request
Jan 16, 2025
* Initial Changes. Signed-off-by: lakde <rohit.lakde@here.com> * Fix Unit Tests Signed-off-by: lakde <rohit.lakde@here.com> * Review Fixes Signed-off-by: lakde <rohit.lakde@here.com> * Update openapi.yaml * Update gradle.properties * Update gradle.properties * Rebase CASL-321 (#371) * Fixed array patching (#365) * Fixed array patching * corrected patcher test expectation * Fix thread stuck issue + addtnl logs (#368) * Added logs to troubleshoot thread hanging issue * CASL-258 unreleased lock fix (#358) * Fixed array patching (#365) (#367) * corrected patcher test expectation * updated version * updated changelog --------- Co-authored-by: Pawel Mazurek <52866094+cyberhead-pl@users.noreply.github.com> --------- Co-authored-by: Hiren Patel <80465571+hirenkp2000@users.noreply.github.com> Co-authored-by: Pawel Mazurek <52866094+cyberhead-pl@users.noreply.github.com> * Update reusable-build-and-publish.yml * Update gradle.properties * Update openapi.yaml * Add Interface IExtensionInit * Add instanceCache logic. * Create ValueTuple.java * loaderCache Changes * Correct logger messages * Update IExtensionInit description * Fix bug * Correct logger in Hub. * Update IExtensionInit Description. * Correct removeExtensionFromCache. * Review Fixes for ExtensionCache * Update ExtensionCache.java * Update NakshaHub.java * Extension Sub Environment Changes (#330) (#392) * Initial Changes. * Fix Unit Tests * Review Fixes * Rebase CASL-321 (#371) * Fixed array patching (#365) * Fix thread stuck issue + addtnl logs (#368) * CASL-258 unreleased lock fix (#358) * updated version * updated changelog * Update reusable-build-and-publish.yml * Update gradle.properties * Update openapi.yaml --------- Signed-off-by: lakde <rohit.lakde@here.com> * Update ExtensionCache.java * Update NakshaHub.java * Update gradle.properties * Update openapi.yaml * Update NakshaVersion.java * Update gradle.properties * Update gradle.properties * Update NakshaVersion.java * Update NakshaHub.java * Support multiple JWT public keys (#395) (#396) * Updated doc about existing JWT loading * added support for additional pub key * updated readme * Updated version to 2.2.1 * Updated doc for pvt and pub key * Added constants in NakshaHubConfig constructor * addressed review comments Co-authored-by: Hiren Patel <80465571+hirenkp2000@users.noreply.github.com> * Update ExtensionCache.java * Update gradle.properties * Update openapi.yaml * Update NakshaVersion.java * Update logger as per review comment. --------- Signed-off-by: lakde <rohit.lakde@here.com> Co-authored-by: Hiren Patel <80465571+hirenkp2000@users.noreply.github.com> Co-authored-by: Pawel Mazurek <52866094+cyberhead-pl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.