Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark reordering fails #63

Closed
grahamperrin opened this issue Mar 28, 2021 · 6 comments
Closed

Bookmark reordering fails #63

grahamperrin opened this issue Mar 28, 2021 · 6 comments

Comments

@grahamperrin
Copy link

From #9 (comment):

attempting to move a bookmark

  1. drag
  2. drop

Expected:

  1. drop in the required place

Actual result:

  1. bounce back to the wrong place.
@probonopd
Copy link
Member

probonopd commented Mar 29, 2021

Cannot reproduce:
Reordering bookmarks works for me on helloSystem build: 0E57 for commit: 80061bf.

computer:/// is not a concept we want to have. Using URLs rather than paths in Filer feels "alien", like if it is coming from Gnome. Why would you want that bookmark anyway, the items from "Computer" are under "Devices". Or are you missing the Startvolume /? That's actually something that should be added under "Devices"... but that's a different issue.

@grahamperrin
Copy link
Author

grahamperrin commented Mar 30, 2021

Today I can't reproduce the issue, but it feels very fiddly.

When I encountered the issue, it's wasn't just fiddly. I tried repeatedly (for a couple of minutes) to drop in a suitable place, it didn't work.

Postscript: today's test was probably limited to a live boot (not the installed system); there were only three bookmarks.

@probonopd
Copy link
Member

Please comment in case you can reproduce it on the unedited Live ISO or unchanged installed system.

@grahamperrin
Copy link
Author

grahamperrin commented Mar 30, 2021

"alien", like if it is coming from Gnome.

I don't use GNOME.

Is there to be prevention of bookmarks?

@grahamperrin
Copy link
Author

There's certainly a bug, probably upstream.

Part of the problem is the plus icon appearing where it should not appear. Bad UX.

@probonopd
Copy link
Member

Is there to be prevention of bookmarks?

No. But the use of URLs for anything but the web might change in favor of Unix paths in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants