Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add buffer-close-others --skip-visible flag #5393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mtoohey31
Copy link
Contributor

@mtoohey31 mtoohey31 commented Jan 4, 2023

This pull request adds the a boolean --skip-visible flag to the buffer-close-others and buffer-close-others! commands, which modifies their behaviour so that instead of closing all buffers except the currently focused one, any other buffers that are visible (i.e. in a split) are also left open.

@mtoohey31 mtoohey31 force-pushed the feat/buffer-close-hidden branch from 0dc79b3 to d9aef1d Compare January 4, 2023 03:38
@kirawi kirawi added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 9, 2023
@mtoohey31 mtoohey31 force-pushed the feat/buffer-close-hidden branch from d9aef1d to 2bb5319 Compare October 13, 2023 01:11
@mtoohey31
Copy link
Contributor Author

Hello! I know it's been a while, but I'm still interested in this. I've rebased it and simplified things as much as possible.

Please let me know if there's something problematic with this or if I'm missing an obvious alternative. If there just hasn't been time to get to it yet though, no worries!

@mtoohey31
Copy link
Contributor Author

I'd still really like to have this... Sorry for the ping @kirawi, but is there anything I can do to move this forward? No worries if there just hasn't been time; admittedly the lack of comments by other users seems to indicate that this might not be something many people have run into, so I understand if it's not a priority. That being said, the changes are quite minimal so I don't think it introduces much extra maintenance burden.

@the-mikedavis
Copy link
Member

I think this could fit as a flag (#5828) on :buffer-close-others(!), so it would be :bco --non-visible or :bco --background (naming is hard)

@mtoohey31
Copy link
Contributor Author

Ok, I'll keep an eye on #12527 then.

@the-mikedavis the-mikedavis added S-waiting-on-pr Status: This is waiting on another PR to be merged first and removed S-waiting-on-review Status: Awaiting review from a maintainer. labels Jan 29, 2025
@mtoohey31 mtoohey31 force-pushed the feat/buffer-close-hidden branch from 2bb5319 to 809327b Compare February 28, 2025 20:39
@mtoohey31 mtoohey31 changed the title feat: add buffer-close-hidden commands feat: add buffer-close-others --skip-visible flag Feb 28, 2025
@mtoohey31
Copy link
Contributor Author

Hi @the-mikedavis, I see that #12527 has been merged, so I've rebased this to make use of that. I've used --skip-visible as the flag name for now (with -s for the short version), though naming is hard as you said, so if you prefer something else lmk.

@the-mikedavis the-mikedavis removed the S-waiting-on-pr Status: This is waiting on another PR to be merged first label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants