Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of non default colors breaks styling #7

Open
188599 opened this issue Oct 9, 2024 · 2 comments
Open

Usage of non default colors breaks styling #7

188599 opened this issue Oct 9, 2024 · 2 comments
Assignees

Comments

@188599
Copy link

188599 commented Oct 9, 2024

Describe the bug

Passing a non default color to the component breaks the styling for selection in the calendar, and marker for the current date.

To Reproduce

No response

Code snippet

No response

Expected behavior

The pre-forked version of the library supported the usage of non-default colors, so I assumed this would too.

Node.js Version

No response

OS

No response

Additional Library Versions

No response

Additional context/Screenshots

Without selecting any color:

With non default color:

@heliomarpm
Copy link
Owner

Can you send a code example please?

@heliomarpm heliomarpm self-assigned this Oct 27, 2024
@188599
Copy link
Author

188599 commented Nov 8, 2024

Well, I ended up doing this to make it work, which I'm not sure if its the intended way, but it works.

    const options: ICalendarModalOptions = {
      //...
      cssClass: 'ion-my-non-default-color',
      color: 'custom',
    };
  ion-calendar-modal {
    --ion-color-custom: var(--ion-color-base);
    --ion-color-custom-rgb: var(--ion-color-base-rgb);
    --ion-color-custom-contrast: var(--ion-color-contrast);
    --ion-color-custom-contrast-rgb: var(--ion-color-contrast-rgb);
    --ion-color-custom-shade: var(--ion-color-shade);
    --ion-color-custom-tint: var(--ion-color-tint);
  }

If this is intended, I think it would be good to add this as an example to the readme section.

@heliomarpm heliomarpm pinned this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants