Enforce hash checks #172
Merged
Enforce hash checks #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…last chunk of the data with sha256
giogix2
reviewed
Jan 17, 2025
|
Have you tested this? Even locally with a few files? I'm asking because the logic where we retrieve the last part of the file might be prone to errors. |
|
Yes I tested locally with local files, also very small ones and get same results. |
bputzeys
commented
Jan 17, 2025
| @@ -188,7 +202,7 @@ def download_via_name(self, name: str) -> None: | |||
| os.makedirs(os.path.dirname(output),exist_ok=True) | |||
| LOGGER.info(f"Creating Folder {os.path.dirname(output)}") | |||
|
|
|||
| if Path(output).is_file() and self.calculate_partial_file_hash(output) == HASH_DICT.get(name): | |||
| if Path(output).is_file() and self.calculate_partial_file_hash(output) == HASH_DICT[name]: | |||
There was a problem hiding this comment.
this is intentional. when a new file is meant to be downloaded but not yet in the hash_dict, you get a key_error, indicating you should update the dict with the new hash
giogix2
approved these changes
Jan 20, 2025
mattwoodx
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.