Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: HyenaDNA variable length input sequences #161

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Bug fix: HyenaDNA variable length input sequences #161

merged 4 commits into from
Dec 18, 2024

Conversation

mattwoodx
Copy link
Contributor

  • HyenaDNA dataset didn't work with inputs that contained different sequence lengths
  • Removed HyenaDNADataset and replaced it with a HF dataset which also streamlines the implementation with some of the other models

@notion-workspace Notion Workspace
Copy link

HyenaDNA dataset only works for sequences of the same length

@mattwoodx mattwoodx marked this pull request as draft December 17, 2024 12:53
@mattwoodx mattwoodx marked this pull request as ready for review December 17, 2024 15:04
giogix2
giogix2 reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@giogix2 giogix2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mattwoodx mattwoodx merged commit 69d0a83 into main Dec 18, 2024
5 checks passed
@mattwoodx mattwoodx deleted the bug/hyena-dna-variable-length-seqs branch December 18, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bputzeys bputzeys bputzeys approved these changes

@giogix2 giogix2 giogix2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattwoodx @giogix2 @bputzeys