implement read-only native queries with no arguments #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
changed the title
dmoverton
reviewed
Mar 18, 2024
dmoverton
reviewed
Mar 18, 2024
| .flat_map(|native_query| &native_query.object_types), | ||
| ); | ||
| let object_types = object_types_from_schema | ||
| .chain(object_types_from_native_queries) |
There was a problem hiding this comment.
Do we check anywhere that there are no duplicate object type names?
There was a problem hiding this comment.
Good point; I added a validating constructor
dmoverton
reviewed
Mar 20, 2024
| let database = config.client.database(&config.database); | ||
|
|
||
| let target = &query_request.target; | ||
| if let Some(native_query) = config.native_queries.iter().find(|query| { |
There was a problem hiding this comment.
I think this is fine for now, but linear search (i.e. find) could lead to performance problems for users who have a lot of native queries. These should eventually be stored in some sort of hashmap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements read-only native queries without arguments. I added a test query called
helloto the fixtures. If you run witharion up -dand access graphiql at http://localhost:7100/ you can try it out.I also added on
objectTypesfield to native query definitions. Object types defined there are merged with object types inschema.jsonso that users can keep hand-written types separate from generated ones.I made some changes to
directory.rsto add more context to configuration-parsing errors in a couple of spots. If we just stick toio::Errorerrors the messages end up being not very helpful.Still to do in follow-up PRs:
Ticket: https://hasurahq.atlassian.net/browse/MDB-85