Separate schema files for each collection #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallettj
approved these changes
Mar 26, 2024
Comment on lines
147
to
153
| // /// Currently only writes `schema.json` | ||
| // pub async fn write_directory( | ||
| // configuration_dir: impl AsRef<Path>, | ||
| // configuration: &Configuration, | ||
| // ) -> anyhow::Result<()> { | ||
| // write_file(configuration_dir, SCHEMA_FILENAME, &configuration.schema).await | ||
| // } |
There was a problem hiding this comment.
Just a little commented code here
| @@ -42,4 +42,23 @@ impl Schema { | |||
| .iter() | |||
| .map(|(name, field)| WithNameRef::named(name, field)) | |||
| } | |||
|
|
|||
| /// Unify two schemas. Assumes that the schemas describe mutually exclusive sets of collections. | |||
| pub fn merge(schema_a: Schema, schema_b: Schema) -> Schema { | |||
There was a problem hiding this comment.
Would it be helpful to emit errors if there are conflicting collection or object type names? I suppose if they're auto-generated it's not likely to come up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Schema files will now be created and read from a subdirectory
schema/containing one schema file per collection.If a collection already has a schema then the
updatecommand skip sampling from the database for that schema.Issue ticket number and link
https://hasurahq.atlassian.net/browse/MDB-83