Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"libpq" constraint of 14.12 seems needlessly high #66

Closed
nikita-volkov opened this issue Aug 31, 2024 · 7 comments
Closed

"libpq" constraint of 14.12 seems needlessly high #66

nikita-volkov opened this issue Aug 31, 2024 · 7 comments

Comments

@nikita-volkov
Copy link

Which leads to failed builds on systems that are compatible. E.g.,

...
checking for the PostgreSQL version... 14.11
checking if PostgreSQL version 14.11 is >= 14.12... no
configure: error: Library requirements (PostgreSQL) not met.
Error: [Cabal-7125]
Failed to build postgresql-libpq-configure-0.11 (which is required by hasql-1.8). See the build log above for details.

Judging by the official docs, pipelining is supported in libpq starting from version 14.

@phadej
Copy link
Collaborator

phadej commented Aug 31, 2024

What's your system running 14.11? Could you upgrade the libpq?

Ubuntu Jammy has 14.13: https://packages.ubuntu.com/jammy/postgresql-14-asn1oid, and I picked 14.12 because that's one installed on GHA Windows CI.

I'm hesitant to use anything I don't test against. 14.13 is the last in 14. series, so perfectly I'd like to require that, unfortunately I have to allow 14.12 for now.

@nikita-volkov
Copy link
Author

Locally I'm running on macOS via brew. It's not a problem to update.

In some situations however it's easier to avoid upgrading the lib than a system dependency. E.g., in my case at work I may have to go thru long communications with colleagues before that can be achieved. So I'm sure more people will be coming with the same request.

@phadej
Copy link
Collaborator

phadej commented Sep 1, 2024

If Ubuntu LTS 22 managed to upgrade promptly to libpq-14.13, I'm quite convinced that the long communications doesn't need to be long. If corporate processes e.g. make it easier to have a local patch to (just released) postgresql-libpq than upgrading libpq (released before), i'm not sorry.

@nikita-volkov
Copy link
Author

Ok. Up to you

@phadej
Copy link
Collaborator

phadej commented Sep 2, 2024

  • 14.13 is released recently, 2024-08-08.
  • 14.12 2024-05-09
  • 14.11 2024-02-08

Looks like PostgreSQL has 3 month minor release cycle.


I checked that

so big distributions are promptly including the new minor releases.


GHA windows image https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md (atm) image version is 20240825.1.0, and includes 14.12 released 2024-05-09


Until there is technical reason why upgrade is not possible, I don't see a reason to relax lower bound. As far as I can see the postgresql version adoption is quite prompt in free software.

@echatav
Copy link

echatav commented Jan 15, 2025

As far as I can see the postgresql version adoption is quite prompt in free software.

Unfortunately this does not appear to be the case, at least in the Haskell tooling ecosystem. See discussion here. Can we reopen this issue and lower the libpq constraint?

@phadej
Copy link
Collaborator

phadej commented Jan 16, 2025

@echatav No. Current postgresql-libpq definitely needs postgres 14. (14.12 vs 14.11 is irrelevant if Hackage docbuilder has 13).

EDIT: For the context, I already waited with the pipelining patch (which requires more recent libpq) longer than some people wanted. I cannot make everyone happy; current setup is hopefully a middle ground. IMHO, Hackage docbuilder just needs people to keep it updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants