Skip to content

Fix misplaced inlay hints by applying PositionMapping #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix misplaced inlay hints by applying PositionMapping #4571

wants to merge 2 commits into from

Conversation

jetjinser
Copy link
Contributor

resolve #4561.

fixed hls-explicit-imports-plugin, hls-explicit-record-fields-plugin.

@jetjinser jetjinser requested a review from ozkutuk as a code owner April 25, 2025 07:48
fendor
fendor approved these changes Apr 25, 2025
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't check this works correctly now, and I am not sure whether we even could add a test for this that isn't incredibly flaky.

@fendor fendor enabled auto-merge (rebase) April 25, 2025 08:09
auto-merge was automatically disabled April 25, 2025 08:25

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@ozkutuk ozkutuk Awaiting requested review from ozkutuk ozkutuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inlay Hints for imports seem to be misplaced
2 participants
@jetjinser @fendor