Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make --tool and --show-criteria 'many' #1238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make --tool and --show-criteria 'many' #1238

wants to merge 1 commit into from

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Mar 4, 2025

Fixes #1235

@ulysses4ever

$ ghcup list -t ghc -t cabal -t ghcup -c +installed -c -set
   Tool  Version            Tags                            Notes
✓  ghc   8.6.5              base-4.12.0.0
✓  ghc   8.8.4              base-4.13.0.0
✓  ghc   8.10.7             base-4.14.3.0
✓  ghc   9.2.8              base-4.16.4.0
✓  ghc   9.4.8              recommended,base-4.17.2.1
✓  ghc   9.6.6              base-4.18.2.1
✓  ghc   9.8.0.20230929     prerelease,base-4.19.0.0        2023-09-29
✓  ghc   9.8.4              base-4.19.2.0                   2024-11-27
✓  ghc   9.10.1             base-4.20.0.0
✓  ghc   9.12.0.20241128    latest-prerelease,base-4.21.0.0 2024-11-28
✓  ghc   9.12.1             latest,base-4.21.0.0            2024-12-15
✓  ghc   9.12.1.20250219    latest-prerelease,base-4.21.0.0 2025-02-24
✓  cabal 3.14.1.1           latest
✓  cabal 3.15.0.0.2024.10.3 latest-prerelease

@ulysses4ever
Copy link
Contributor

thank you, this looks like a good improvement. #1235 isn't about multiple filtering conditions, though. It's about -t being counter-intuitive, at least, for me. In that, this patch does nothing to address the issue. But you seem to feel like the price to pay for consistency between list and other commands is reasonable. I tend to disagree because I don't see how this particular consistency is helping anything. For me, it hurts UX more than it helps. But I can survive it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: ghcup list should be able to filter by tool
2 participants