Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreliable dependencies #1093

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Remove unreliable dependencies #1093

merged 3 commits into from
Jul 7, 2024

Conversation

hasufell
Copy link
Member

@hasufell hasufell commented Jul 5, 2024

See #1092 and #1089

@hasufell hasufell marked this pull request as draft July 5, 2024 16:01
@hasufell
Copy link
Member Author

hasufell commented Jul 5, 2024

@jasagredo

@hasufell
Copy link
Member Author

hasufell commented Jul 5, 2024 •
edited
Loading

https://github.com/haskell/ghcup-hs/actions/runs/9810889018/job/27096599505?pr=1093#step:6:7552

2024-07-05T18:58:17.2039026Z �[1m[ Error ]�[0m [�]8;;https://errors.haskell.org/messages/GHCup-00200�\GHCup-00200�]8;;�\] Digest error for /github/workspace/.ghcup/cache/ghc-8.10.3-armv7-deb10-linux.tar.xz: expected b823b58cae36fbac0741680ca7605180fa4cf4c6ae439123d282184b94d32fd6 but got a4ab25701d29a35dfd9124e48dfcb5850437a2b29e72fa36d22654b4d1b11a03

Quite odd. The expected hash is indeed b823b58cae36fbac0741680ca7605180fa4cf4c6ae439123d282184b94d32fd6 and I can't reproduce the error.

@Bodigrim
Copy link
Collaborator

Bodigrim commented Jul 5, 2024

Quite odd. The expected hash is indeed b823b58cae36fbac0741680ca7605180fa4cf4c6ae439123d282184b94d32fd6 and I can't reproduce the error.

Presumably it's GaloisInc/SHA#16

@Bodigrim
Copy link
Collaborator

Bodigrim commented Jul 5, 2024

SHA package is likely to be magnitudes slower than cryptohash-sha256, I'd pretty much recommend not to change this.

@hasufell hasufell added this to the 0.1.30.0 milestone Jul 7, 2024
Bodigrim
Bodigrim reviewed Jul 7, 2024
View reviewed changes
lib/GHCup/CabalConfig.hs
-- | Find the @~\/.cabal\/config@ file.
findConfig :: IO FilePath
findConfig = do
env <- lookupEnv "CABAL_CONFIG"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cabal >= 3.12 you can query cabal path | grep store-dir.

@hasufell hasufell marked this pull request as ready for review July 7, 2024 11:57
@hasufell hasufell merged commit 41c3a08 into master Jul 7, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bodigrim Bodigrim Bodigrim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hasufell @Bodigrim