Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test more versions of GHC on CI #71

Closed
wants to merge 2 commits into from
Closed

Test more versions of GHC on CI #71

wants to merge 2 commits into from

Conversation

sol
Copy link
Member

@sol sol commented Jan 31, 2021

No description provided.

@sol sol marked this pull request as ready for review January 31, 2021 22:23
@sol sol marked this pull request as draft January 31, 2021 22:26
@sol sol force-pushed the ci branch 2 times, most recently from df7fef6 to cd81e2e Compare January 31, 2021 23:13
@sol sol marked this pull request as ready for review January 31, 2021 23:14
@sol
Copy link
Member Author

sol commented Jan 31, 2021

@RyanGlScott are you ok with renaming master to main?

7.2.1 seems to be failing because of some SafeHaskell issue. This is something we might want to fix, if possible.

@sol sol requested a review from RyanGlScott January 31, 2021 23:20
@sol sol self-assigned this Jan 31, 2021
@sol
Copy link
Member Author

sol commented Jan 31, 2021

Same for 7.4.1, SafeHaskell. I disabled fail-fast for now, so that we see which minor versions have issues.

All the versions that were tested on Travis work fine (I had a good build for them before https://github.com/haskell-compat/base-compat/actions/runs/526141035).

@sol sol changed the title Add .github/workflows/build.yml Test more versions of GHC on CI Feb 1, 2021
@sol
Copy link
Member Author

sol commented Feb 1, 2021

I opened #72. It tests the versions of GHC that we had on Travis + it's ready to merge. This PR enables more GHCs and can be considered separately.

@RyanGlScott
Copy link
Member

If I recall correctly, the build failures all concern the base-compat-batteries package in particular. Before #65, when I gave up on the idea of trying to maintain CI for every minor release of GHC, I maintained this collection of hacks to support particular minor releases of GHC. It's likely that many of the issues you encounter here were also documented in that collection of hacks.

@sol sol closed this Dec 19, 2021
@sol sol deleted the ci branch December 19, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants