Introduce base-compat-batteries in preparation for a 8.4-ready release #43
Conversation
| module Base | ||
| #if !(MIN_VERSION_base(4,9,0)) | ||
| , Semi.Semigroup((Semi.<>)) | ||
| #endif |
There was a problem hiding this comment.
Would it make sense to depend and re-export base-orphans's Data.Orphans?
There was a problem hiding this comment.
I pondered this. There's at least two complications:
- Some folks want to avoid orphan instances as much as possible.
- We'd need to reexport it from every module in this library if we want to be sure it's available everywhere.
As a result, I decided not to pursue this further.
There was a problem hiding this comment.
Good. Should that be documented in readme?
| @@ -0,0 +1,37 @@ | |||
| {-# LANGUAGE CPP, NoImplicitPrelude #-} | |||
| module Data.Semigroup.Compat ( | |||
There was a problem hiding this comment.
I wonder, should there be a (haddock) note that (some) symbols are only for base-4.9?
| , WrappedMonoid(..) | ||
| -- * Re-exported monoids from Data.Monoid | ||
| , Dual(..) | ||
| , Endo(..) |
There was a problem hiding this comment.
those could be exported for older base too, but it's not biggie.
There was a problem hiding this comment.
Indeed. I don't think I'll lose sleep over this, though, since they're simply reexports from Data.Monoid(.Compat), so folks will likely reach for that over Data.Semigroup.Compat.
…askell-compat#43) (requires an sol/hpack@verbatim)
This introduces
base-compat-batteries, a variant ofbase-compatthat depends on compatibility packages. Lots of internal reshuffling of the repo had to occur to make this happen, so this diff is quite large. Of note:base-compat/README.mdfor an exact list of things thatbase-compatcompared tobase-compat-batteries.checktest suite now usesbase-compat-batteries, as it exposes the same API across more versions ofbasethanbase-compatdoes now.base-compathas been migrated tobase-compat-batteries, as it makes more sense to have a single home for it, andbase-compat-batteriesis strictly more defined.Fixes #36, and checks off the 8.4-related boxes in #24.