Replace custom inode-based file comparison with os.SameFile. #36562
+10
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment was marked as resolved.
This comment was marked as resolved.
SarahFrench
reviewed
Feb 21, 2025
There was a problem hiding this comment.
👋🏻 Hi, thanks for opening a PR!
It looks like the CLA automation is having trouble due to the commit you pushed lacking any email information in the author info. Could you please re-create the commit so that there's an email included that's also linked to your GitHub account?
Gofastasf
force-pushed
the
refactor/remove-custom-inode-check
branch
from
297f44b to
a6b6db8
Compare
|
Hey Sarah that was a mistake. Recreated with email now. |
SarahFrench
added
the
no-changelog-needed
Remove inode.go, inode_freebsd.go, and inode_windows.go, eliminating platform-specific inode lookup logic. Replace sameFile function with os.SameFile, simplifying file comparison logic.
Gofastasf
force-pushed
the
refactor/remove-custom-inode-check
branch
from
09756cd to
3afdc81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove inode.go, inode_freebsd.go, and inode_windows.go, eliminating platform-specific inode lookup logic.
Call os.Stat on dstPath to obtain os.FileInfo since os.SameFile requires FileInfo objects for comparison and not raw string.
Replace sameFile function with os.SameFile, simplifying file comparison logic.
This change is not user-facing.