-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add credential_type and credential_config to static roles for DBs #2384
base: main
Are you sure you want to change the base?
Conversation
ea109b6
to
a2ac1e7
Compare
Unsure what "all supported Vault versions" are so I ran my tests against 1.18.2 locally. https://registry.terraform.io/providers/hashicorp/vault/latest/docs does not list any supported versions. Nor in the README from what I can tell. |
My organization would benefit greatly from this feature. As was pointed out on the issue #1585, switching from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @catouc! Looking good so far. If you can kindly address the comments we can get this PR merged.
d1bf505
to
3079c1c
Compare
All addressed, also rewrote the commit msg to be a bit more in line with the rest of the repositories changes. |
Gonna link #2399 into here since this issue seems to be getting more traction with Snowflakes deprecation of password auth. |
Moved the changelog to the correct part. |
This adds two new fields: * credential_type * credential_config To `vault_database_secret_backend_static_role`.
@fairclothjm maybe we can review this now before I have fix even more merge conflicts? :) Thanks for the help! |
Description
An attempt to add
credential_type
andcredential_config
as fields to the static roles in database engines.This is to enable support for using
rsa_public_key
on Snowflake secret engines which is currently not possible on static roles.Closes #1585.
Closes #1992
Checklist
Output from acceptance testing:
Community Note