Made filestore backup tests use sweepable resources (#13009) (#21317)

[upstream:37390d359c66e0c8c4917fe8a4be1d5dab6440c2] Signed-off-by: Modular Magician <magic-modules@google.com>
hashicorp · Feb 7, 2025 · e12bb4c · e12bb4c
1 parent 76e2d83
commit e12bb4c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 8 deletions.
diff --git a/.changelog/13009.txt b/.changelog/13009.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google/services/filestore/resource_filestore_backup_generated_test.go b/google/services/filestore/resource_filestore_backup_generated_test.go
@@ -58,7 +58,7 @@ func TestAccFilestoreBackup_filestoreBackupBasicExample(t *testing.T) {
 func testAccFilestoreBackup_filestoreBackupBasicExample(context map[string]interface{}) string {
 	return acctest.Nprintf(`
 resource "google_filestore_instance" "instance" {
-  name     = "tf-test-tf-fs-inst%{random_suffix}"
+  name     = "tf-test-fs-inst%{random_suffix}"
   location = "us-central1-b"
   tier     = "BASIC_HDD"
 
@@ -75,7 +75,7 @@ resource "google_filestore_instance" "instance" {
 }
 
 resource "google_filestore_backup" "backup" {
-  name              = "tf-test-tf-fs-bkup%{random_suffix}"
+  name              = "tf-test-fs-bkup%{random_suffix}"
   location          = "us-central1"
   description       = "This is a filestore backup for the test instance"
   source_instance   = google_filestore_instance.instance.id

diff --git a/google/services/filestore/resource_filestore_backup_test.go b/google/services/filestore/resource_filestore_backup_test.go
@@ -14,8 +14,8 @@ import (
 func TestAccFilestoreBackup_update(t *testing.T) {
 	t.Parallel()
 
-	instName := fmt.Sprintf("tf-fs-inst-%d", acctest.RandInt(t))
-	bkupName := fmt.Sprintf("tf-fs-bkup-%d", acctest.RandInt(t))
+	instName := fmt.Sprintf("tf-test-fs-inst-%d", acctest.RandInt(t))
+	bkupName := fmt.Sprintf("tf-test-fs-bkup-%d", acctest.RandInt(t))
 
 	acctest.VcrTest(t, resource.TestCase{
 		PreCheck:                 func() { acctest.AccTestPreCheck(t) },
@@ -121,8 +121,8 @@ func TestAccFilestoreBackup_tags(t *testing.T) {
 	t.Parallel()
 
 	org := envvar.GetTestOrgFromEnv(t)
-	instanceName := fmt.Sprintf("tf-fs-inst-%d", acctest.RandInt(t))
-	backupName := fmt.Sprintf("tf-fs-bkup-%d", acctest.RandInt(t))
+	instanceName := fmt.Sprintf("tf-test-fs-inst-%d", acctest.RandInt(t))
+	backupName := fmt.Sprintf("tf-test-fs-bkup-%d", acctest.RandInt(t))
 	tagKey := acctest.BootstrapSharedTestTagKey(t, "filestore-backups-tagkey")
 	tagValue := acctest.BootstrapSharedTestTagValue(t, "filestore-backups-tagvalue", tagKey)
 

diff --git a/website/docs/r/filestore_backup.html.markdown b/website/docs/r/filestore_backup.html.markdown
@@ -39,7 +39,7 @@ To get more information about Backup, see:
 
 ```hcl
 resource "google_filestore_instance" "instance" {
-  name     = "tf-fs-inst"
+  name     = "fs-inst"
   location = "us-central1-b"
   tier     = "BASIC_HDD"
 
@@ -56,7 +56,7 @@ resource "google_filestore_instance" "instance" {
 }
 
 resource "google_filestore_backup" "backup" {
-  name              = "tf-fs-bkup"
+  name              = "fs-bkup"
   location          = "us-central1"
   description       = "This is a filestore backup for the test instance"
   source_instance   = google_filestore_instance.instance.id