net: correctly return and handle started response with no network. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible operators do not configure a network for a VM driver task. In this case, the plugin should correctly handle the response from the network controller. Along with the main fix, the change updates the controller responses, so that an object is returned when there isn't an error. This is because returning nil,nil is a weird pattern in Go and catches people out; even the person that wrote it.
Juanadelacuesta
force-pushed
the
b-fix-handling-no-network-config
branch
from
1ffc370
to
3933e8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible operators do not configure a network for a VM driver task. In this case, the plugin should correctly handle the response from the network controller.
Along with the main fix, the change updates the controller responses, so that an object is returned when there isn't an error. This is because returning nil,nil is a weird pattern in Go and catches people out; even the person that wrote it.