Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetLevel
toLevel
to be more idiomatic Go (https://go.dev/doc/effective_go#Getters)log
methods so they return if someone tries to log atOff
level toovalues.go
receivers forIsX
checking forDebug
all the time https://github.com/hashicorp/go-hclog/pull/143/files#diff-e7a71de986f0a776ec8024ba579fe753d2410f900cf9ecb9d05e37c3276e8c46R68-R95Just as a personal view, I'm not sure about the
LogImpl
name, but I don't know what's better, I added a// TODO:
comment in there somewhere but it can be ignored in your PR if you'd like. I won't be too offended 😄