Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(showcase): speed up tests in CI #2176

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(showcase): speed up tests in CI #2176

wants to merge 4 commits into from

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented Jun 19, 2024

📌 Summary

This change cuts component tests in CI by 50%, today on average it takes around 4 minutes with this change we reduce it to 2 minutes.

The only potential issue I see is this message:

[percy] Error: This organization has exceeded the limits of the Percy BrowserStack plan. Administrators can upgrade here: https://percy.io/organizations/587d9efb/billing

🛠️ Detailed description

📸 Screenshots

Before:

Screenshot 2024-06-18 at 7 47 49 PM

After:

Screenshot 2024-06-18 at 7 48 27 PM

🔗 External links

Jira ticket: HDS-XXX
Figma file: [if it applies]


👀 Component checklist

💬 Please consider using conventional comments when reviewing this PR.

@aklkv aklkv self-assigned this Jun 19, 2024
Copy link

vercel bot commented Jun 19, 2024

You must have Developer access to commit code to HashiCorp on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

@aklkv aklkv force-pushed the feat/speedup-test branch 5 times, most recently from 912aeed to 490ca6a Compare June 19, 2024 02:38
@aklkv aklkv marked this pull request as ready for review June 19, 2024 02:49
@aklkv aklkv force-pushed the feat/speedup-test branch 6 times, most recently from 3e6d3b4 to 0a03478 Compare June 19, 2024 03:14
@Dhaulagiri
Copy link
Contributor

FWIW the percy message is not unique to this PR. I see it in others as well.

Copy link
Member

@alex-ju alex-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, using ember-exam sounds like a good idea for introducing parallel testing.

I've only been able to compare test:ember (not including the VRT testing in Percy) and the differences are marginal (2m12s, compared to 2m20s for main); However, it could make all the difference on test:ember:percy, but we seem to have some challenges around using Percy so not able to test that atm.

showcase/testem.js Show resolved Hide resolved
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hds-showcase ✅ Ready (Inspect) Visit Preview Aug 3, 2024 10:36am
hds-website ✅ Ready (Inspect) Visit Preview Aug 3, 2024 10:36am

@aklkv
Copy link
Contributor Author

aklkv commented Jun 20, 2024

Generally, using ember-exam sounds like a good idea for introducing parallel testing.

I've only been able to compare test:ember (not including the VRT testing in Percy) and the differences are marginal (2m12s, compared to 2m20s for main); However, it could make all the difference on test:ember:percy, but we seem to have some challenges around using Percy so not able to test that atm.

I tried adding ember-exam to website tests but it didn't result in much savings so I thought there wouldn't be much sense in adding it at this stage. I am happy to add this instrumentation here as well for consistency.

On the other hand showcase test were much more cooperative and we can see ~2 min saving

@aklkv
Copy link
Contributor Author

aklkv commented Jun 20, 2024

FWIW the percy message is not unique to this PR. I see it in others as well.

oh, good to know I thought ember-exam parallel runs triggered this warning

@Dhaulagiri
Copy link
Contributor

Percy is fixed now so we could re-run the comparisons to see if the improvement in perf you were seeing was related to the introduction of ember-exam or a coincidence because percy tests were no longer running

@aklkv
Copy link
Contributor Author

aklkv commented Jun 27, 2024

@Dhaulagiri I think I got it fixed so the tests aren't flaking anymore but but speed gains are a little less we are sitting at 2m 45s which is still a good reduction

@Dhaulagiri
Copy link
Contributor

@aklkv apologies for the delay on this. lost track of this over the holiday.

the time savings is relatively small but it is faster overall, so this seems worth bringing in to me given the low cost to opt-in to this feature. @alex-ju any objections from your perspective?

@aklkv
Copy link
Contributor Author

aklkv commented Jul 31, 2024

@Dhaulagiri No worries at all. One thing I noticed that Percy is still in Pending state, I wonder if this is something related to my changes

@Dhaulagiri
Copy link
Contributor

🤔

Only 3 of the 8 parallelized build processes reported they were finished.

@Dhaulagiri
Copy link
Contributor

I was doing a a lot of manual starting/stopping of the tests to test this so that may be part of it, but we may also need to try following all the instructions here.

@alex-ju
Copy link
Member

alex-ju commented Aug 2, 2024

the time savings is relatively small but it is faster overall, so this seems worth bringing in to me given the low cost to opt-in to this feature. @alex-ju any objections from your perspective?

no objections, any improvement is progress. I'll try and give this PR a fresh pair of eyes today or on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants