Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): Updates from 0.18.0 testing #2509

Merged
merged 4 commits into from
Oct 4, 2024
Merged

test(e2e): Updates from 0.18.0 testing #2509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8eca327
test(e2e): Update locators that can't be found
moduli Oct 2, 2024
de1f38c
test(e2e): Fix race condition
moduli Oct 2, 2024
dcd9953
CR: Fix Alias header check
moduli Oct 3, 2024
5f80e79
Merge branch 'main' into moduli-e2e-0.18.0
moduli Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ui/admin/tests/e2e/pages/auth-methods.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export class AuthMethodsPage extends BaseResourcePage {
.getByRole('navigation', { name: 'IAM' })
.getByRole('link', { name: 'Auth Methods' })
.click();
await this.page.getByRole('button', { name: 'Manage' }).click();
await this.page.getByText('Make Primary', { exact: true }).click();
await this.page.getByLabel('Manage').click();
await this.page.getByRole('button', { name: 'Make Primary' }).click();
await this.page.getByText('OK', { exact: true }).click();
await this.dismissSuccessAlert();
}
Expand All @@ -52,7 +52,7 @@ export class AuthMethodsPage extends BaseResourcePage {
* Removes auth method as primary. Assume you have selected the desired auth method.
*/
async removeAuthMethodAsPrimary() {
await this.page.getByTitle('Manage').click();
await this.page.getByRole('button', { name: 'Manage' }).click();
await this.page.getByRole('button', { name: 'Remove as primary' }).click();
await this.page.getByText('OK', { exact: true }).click();
await this.dismissSuccessAlert();
Expand Down
6 changes: 6 additions & 0 deletions ui/admin/tests/e2e/tests/alias-ent.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ test.describe('Aliases (Enterprise)', async () => {

// Clear destination from alias
await page.getByRole('link', { name: alias }).click();
// Note: On the Target details page, there is a section with the header
// "Aliases". The extra check here is to ensure that we are on the Alias
// details page and not the Target details page.
await expect(
page.getByRole('heading', { name: 'Alias' }),
).not.toHaveText('Aliases');
await page.getByRole('button', { name: 'Manage' }).click();
await page.getByText('Clear', { exact: true }).click();
await page.getByText('OK', { exact: true }).click();
Expand Down
6 changes: 6 additions & 0 deletions ui/admin/tests/e2e/tests/alias.spec.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ test.describe('Aliases', async () => {

// Clear destination from alias
await page.getByRole('link', { name: alias }).click();
// Note: On the Target details page, there is a section with the header
// "Aliases". The extra check here is to ensure that we are on the Alias
// details page and not the Target details page.
await expect(
page.getByRole('heading', { name: 'Alias' }),
).not.toHaveText('Aliases');
await page.getByRole('button', { name: 'Manage' }).click();
await page.getByText('Clear', { exact: true }).click();
await page.getByText('OK', { exact: true }).click();
Expand Down