Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Updates from 0.18.0 testing #2509

Merged
merged 4 commits into from
Oct 4, 2024
Merged

test(e2e): Updates from 0.18.0 testing #2509

merged 4 commits into from
Oct 4, 2024

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented Oct 2, 2024

This PR updates some Admin UI e2e tests based on testing it against Boundary 0.18.0. There were two changes here

  • On the Auth Methods page, the Manage button and some of its options were not being found by the current selectors. Those selectors were updated.
  • On the Alias test, for some reason, it was starting to fail more often due to what seems like a timing issue. The test's intention is to navigate from the Target details page to the associated Alias details page in order to clear its value. What seems like is happening...
    • Test is on Target details page
    • Test clicks on associated Alias to go to Alias details page
    • Test clicks Manage button
      • It seems like the test is clicking the Manage button on the Target details page (before the Alias page finishes loading)
    • The PR now adds a check to ensure that the Alias details page has loaded

Testing

Tests against CE and ENT on both docker and aws infra were updated

# boundary
enos scenario launch e2e_ui_docker builder:local
yarn run e2e:ce:docker

enos scenario launch e2e_ui_aws builder:local
yarn run e2e:ce:aws

# boundary-enterprise
enos scenario launch e2e_ui_docker_ent builder:local
yarn run e2e:ent:docker

enos scenario launch e2e_ui_aws_ent builder:local
yarn run e2e:ent:aws

https://hashicorp.atlassian.net/browse/ICU-15234

It seems like the alias tests were failing as it was unable to open the Manage menu here. One theory is that we need to make sure the alias page has fully loaded before it tries to click the Manage button (the test might be finding the Manage button from the previous screen and clicking that)
@moduli moduli requested a review from calcaide October 2, 2024 20:59
@moduli moduli requested a review from a team as a code owner October 2, 2024 20:59
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 4:08pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 4:08pm

@calcaide
Copy link
Collaborator

calcaide commented Oct 3, 2024

I am reproducing 1 issue (across all browsers) when running yarn run e2e:ce:aws.

Screenshot 2024-10-03 at 4 00 53 PM

Screenshot from the failure:
test-failed-1

As per the failure screenshot, seems like the "Manage" dropdow does not open.

Let me know if you want me to re-run 😉

@calcaide
Copy link
Collaborator

calcaide commented Oct 3, 2024

I am reproducing one issue running yarn run e2e:ent:docker under boundary-ui-enterprise. The issue reproduces within the 3 browsers

Screenshot 2024-10-03 at 4 30 32 PM Screenshot 2024-10-03 at 4 30 50 PM

test-failed-1

@moduli
Copy link
Collaborator Author

moduli commented Oct 3, 2024

@calcaide

  • The first issue was supposed to be what I addressed. I'm not able to reproduce this on my machine yet. Still trying.
  • The second issue was mentioned in the boundary-ui channel. There's a bug that someone is working on.

@calcaide
Copy link
Collaborator

calcaide commented Oct 3, 2024

@calcaide

  • The first issue was supposed to be what I addressed. I'm not able to reproduce this on my machine yet. Still trying.
  • The second issue was mentioned in the boundary-ui channel. There's a bug that someone is working on.

@moduli I am running the last set of tests yarn run e2e:ent:aws. Since the 2 other errors reported are under control, I will proceed to approve this PR as soon the test suite finishes 😉

@moduli
Copy link
Collaborator Author

moduli commented Oct 3, 2024

@calcaide Pushed up a fix. Let me know if it resolves it on your end.

@calcaide
Copy link
Collaborator

calcaide commented Oct 4, 2024

@calcaide Pushed up a fix. Let me know if it resolves it on your end.

@moduli The fix works!! tests pass as expected 🥳

Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the terrific work 🙌

@moduli moduli merged commit 9c31154 into main Oct 4, 2024
12 checks passed
@moduli moduli deleted the moduli-e2e-0.18.0 branch October 4, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants