Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 bucket types icon in target association #2503

Merged
merged 5 commits into from
Sep 27, 2024
Merged

fix: 🐛 bucket types icon in target association #2503

merged 5 commits into from
Sep 27, 2024

Conversation

DhariniJeeva
Copy link
Collaborator

@DhariniJeeva DhariniJeeva commented Sep 25, 2024 •
edited
Loading

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15186

jira

Description

Fixes storage bucket types

Screenshots (if appropriate)

minIO:
Screenshot 2024-09-25 at 2 36 36 PM

AWS:
Screenshot 2024-09-25 at 2 36 43 PM

unknown:
Screenshot 2024-09-25 at 3 06 34 PM

How to Test

  • create a minIO type storage bucket and the icon and type should be updated in the target association page
  • you can also check this using mirage by going to an SSH target type and keep refreshing to see different types

Checklist

  • I have added before and after screenshots for UI changes
  • [ ] I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works

@DhariniJeeva DhariniJeeva requested a review from a team as a code owner September 25, 2024 22:28
@vercel Vercel
Copy link

vercel bot commented Sep 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:08pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:08pm

@DhariniJeeva DhariniJeeva self-assigned this Sep 25, 2024
@DhariniJeeva DhariniJeeva force-pushed the ICU-15186-update-icon-and-text-based-on-storage-bucket-type branch from 76cc843 to eef7762 Compare September 25, 2024 23:12
lisbet-alvarez
lisbet-alvarez approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for fixing this!!

ZedLi
ZedLi approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ui/admin/app/routes/scopes/scope/targets/target/index.js Outdated Show resolved Hide resolved
calcaide
calcaide approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@calcaide calcaide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@DhariniJeeva DhariniJeeva merged commit 9b33812 into main Sep 27, 2024
12 checks passed
@DhariniJeeva DhariniJeeva deleted the ICU-15186-update-icon-and-text-based-on-storage-bucket-type branch September 27, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedLi ZedLi ZedLi approved these changes

@calcaide calcaide calcaide approved these changes

@cameronperera cameronperera cameronperera approved these changes

@lisbet-alvarez lisbet-alvarez lisbet-alvarez approved these changes

Assignees

@DhariniJeeva DhariniJeeva

Labels
addons admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DhariniJeeva @ZedLi @calcaide @cameronperera @lisbet-alvarez