Llb ts desktop no cli #2491
Merged
Llb ts desktop no cli #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add CLI_SETUP and delete BYPASS_CLI_BUILD * Apply suggestions from code review Co-authored-by: Zhihe Li <zhihe.li@hashicorp.com> * Fix condition at CLI setup * Change CLI_SETUP to SETUP_CLI --------- Co-authored-by: Zhihe Li <zhihe.li@hashicorp.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Delete BYPASS_CLI_BUILD and base the decision of copying CLI based on the existance of the cli directory.
* Add a method to check when we are using the built in CLI. Use the previously mentioned check to skip the appUpdater if the DC is NOT using the built in CLI
* fix: 🐛 windows no cli build crash
ZedLi
approved these changes
Oct 4, 2024
cameronperera
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces all the changes and fixes need to perform desktop client builds without CLI.
This PR is the LLB being merge to main, work here has been pre approved in separate PR's.