-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: 💡 change channel app state title & add alert msg #2489
refactor: 💡 change channel app state title & add alert msg #2489
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
...es/scopes/scope/session-recordings/session-recording/channels-by-connection/channel/index.js
Outdated
Show resolved
Hide resolved
...es/scopes/scope/session-recordings/session-recording/channels-by-connection/channel/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, left a non blocking comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
...es/scopes/scope/session-recordings/session-recording/channels-by-connection/channel/index.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
…-when-session-recording-integrity-validation-fails
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11148
Description
slack thread for context
Add alert messages for api errors when failing to download recording.
Update app state title to be more generic.
Screenshots (if appropriate)
Screen.Recording.2024-09-12.at.2.16.18.PM.mov
How to Test
Checklist