Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 change channel app state title & add alert msg #2489

Conversation

lisbet-alvarez
Copy link
Collaborator

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-11148

Description

slack thread for context
Add alert messages for api errors when failing to download recording.
Update app state title to be more generic.

Screenshots (if appropriate)

Screen.Recording.2024-09-12.at.2.16.18.PM.mov

How to Test

  1. Create a session-recording
  2. Modify any one of the session-recording files in the aws s3 storage bucket
  3. Navigate to the session-recording channel
  4. Attempt to play the recording and observe the error being displayed as an alert.

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:17pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:17pm

@lisbet-alvarez lisbet-alvarez marked this pull request as ready for review September 12, 2024 21:19
@lisbet-alvarez lisbet-alvarez requested a review from a team as a code owner September 12, 2024 21:19
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, left a non blocking comment

Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

…-when-session-recording-integrity-validation-fails
@lisbet-alvarez lisbet-alvarez merged commit c4e58fb into main Sep 13, 2024
12 checks passed
@lisbet-alvarez lisbet-alvarez deleted the ICU-11148-tob-hcb-10-ui-displays-wrong-error-when-session-recording-integrity-validation-fails branch September 13, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants