-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create HIP: Add Cancun Opcodes (TSTORE, TLOAD, MCOPY) #865
Conversation
HIP to add three Cancun opcodes to the EVM: TSTORE, TLOAD, and MCOPY.. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, left minor feedback
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I left some details
## How to Teach This | ||
|
||
Any smart contract tutorials will want to examine the possibility of adding | ||
sample contracts showcasing the use of transient storage and easy memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that MCOPY
will have more impact on compilers and low-level assembly devs rather than Solidity devs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are explicit ways to trigger mcopy, such as assembly blocks. Gas golfers will want to see it.
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com> Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Description:
HIP to add three Cancun opcodes to the EVM: TSTORE, TLOAD, and MCOPY.
Related issue(s):
Fixes #
Notes for reviewer:
This is one of four related Cancun HIPs. Because of the broad coverage it was broken into 4 pieces.
Checklist