Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HIP: Add Cancun Opcodes (TSTORE, TLOAD, MCOPY) #865

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jan 24, 2024

Description:

HIP to add three Cancun opcodes to the EVM: TSTORE, TLOAD, and MCOPY.

Related issue(s):

Fixes #

Notes for reviewer:

This is one of four related Cancun HIPs. Because of the broad coverage it was broken into 4 pieces.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

HIP to add three Cancun opcodes to the EVM: TSTORE, TLOAD, and MCOPY..

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit a147935
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/65c28a78ed3524000856be7f
😎 Deploy Preview https://deploy-preview-865--hedera-hips.netlify.app/hip/hip-865
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shemnon shemnon marked this pull request as ready for review January 24, 2024 21:16
@shemnon shemnon mentioned this pull request Jan 24, 2024
2 tasks
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@shemnon shemnon marked this pull request as draft February 1, 2024 17:36
@shemnon shemnon marked this pull request as ready for review February 1, 2024 17:37
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, left minor feedback

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
@david-bakin-sl david-bakin-sl changed the title Create HIP: Add Cancun Opcodes Create HIP: Add Cancun Opcodes (TSTORE, TLOAD, MCOPY) Feb 5, 2024
david-bakin-sl
david-bakin-sl previously approved these changes Feb 5, 2024
Copy link
Member

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I left some details

## How to Teach This

Any smart contract tutorials will want to examine the possibility of adding
sample contracts showcasing the use of transient storage and easy memory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that MCOPY will have more impact on compilers and low-level assembly devs rather than Solidity devs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are explicit ways to trigger mcopy, such as assembly blocks. Gas golfers will want to see it.

Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@shemnon shemnon merged commit 65e2262 into hashgraph:main Feb 14, 2024
6 checks passed
kantorcodes pushed a commit to kantorcodes/hedera-improvement-proposal that referenced this pull request Feb 16, 2024
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
kimbor pushed a commit to kimbor/hedera-improvement-proposal that referenced this pull request Jun 24, 2024
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants