-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancun Support HIPs #856
Cancun Support HIPs #856
Conversation
…al into danno-cancun-support
…al into danno-cancun-support Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments for HIP for TLOAD, TSTORE and MCOPY
No ideas were rejected around these three opcodes, aside from not supporting | ||
Cancun features. | ||
|
||
The idea of supporting [EIP-4788](https://eips.ethereum.org/EIPS/eip-4788): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to mention 4788 in this HIP.
This section can be reduced to just your opening sentence No ideas were rejected around these three opcodes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of these HIPs needs to addres beacon root. So I don't think simply deleting it is the right thing to do. Perhaps moving it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed "Add EVM compatibility for non-supported Cancun blob features." HIP doc
HIP/hip-0000-cancun-2.md
Outdated
transaction is being simulated and reject the transaction before sending it to | ||
the simulation and estimation engines. | ||
|
||
### Hedera Activation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed "Add Smart Contract Services Support for KZG Point Evaluation Precompiled Function"
While Hedera will not be supporting most EIP-4844 features the KZG Point | ||
Evaluation Precompile is cleanly severable from the other integrated features. | ||
This precompile, when accompanied by the associated trusted setup, can be viewed | ||
as a cryptographic primitive similar to ECDSA. The ability to proved subsets of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The ability to proved subsets..." needs to be clarified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed "Support Cancun Self-Destruct Semantics in Smart Contract Services"
in my contracts to sweep out hbar while not destroying the contract. | ||
* As a smart contract developer I want to be able to continue to use the | ||
transient contract pattern and have it behave the same way prior to this HIP. | ||
* As a HAPI user I want to be able to control my contract account in the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is an actual user story. Should be clear what flow should be possible or not possible
|
||
### Hedera Services | ||
|
||
Hedera services may need to be changed to ensure that the transaction processing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transient self-destructs should result in a ContractCreate
and a ContractDelete
synthetic transactions for network consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added working group suggestions based on previous conversations.
Please add anyone I left out based on design impact
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Description:
Four hips that cover Hedera support for Cancun changes to the EVM.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist