Updating ContractCreate limits
#1131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
Signed-off-by: Edward Wertz <edward@swirldslabs.com>
jsync-swirlds
approved these changes
Feb 24, 2025
| 128KB, we improve Ethereum compatibility, developer experience, and make it easier to operate a JSON-RPC relay. | ||
| Ethereum and other EVM networks permit significantly larger amounts of data in a call, upto 7.15 MB of call data, | ||
| whereas all Hedera transactions are capped at 6KB. Smart contracts that are larger than 6KB have to be uploaded | ||
| through the Hedera File Service (HFS) through a `FileCreate` transaction followed by multiple `FileAppend` |
There was a problem hiding this comment.
Slight wording improvement.
Suggested change
| through the Hedera File Service (HFS) through a `FileCreate` transaction followed by multiple `FileAppend` | |
| to the Hedera File Service (HFS) through a `FileCreate` transaction followed by multiple `FileAppend` |
| through the Hedera File Service (HFS) through a `FileCreate` transaction followed by multiple `FileAppend` | ||
| transactions. Not only does this lead to a poor developer experience, but it makes operating a JSON-RPC relay | ||
| difficult and expensive. By permitting smart contracts to have 24576 bytes in `initcode` and `constructorParamaters` | ||
| we enable parity with Ethereum smart contract size. Allowing contract call data upto 128KB provides parity with |
| 6KB limit is highly problematic for developer experience, and unexpectedly, for network efficiency. This is especially | ||
| true when creating contracts, and for oracles sending large amounts of data to the network. | ||
| for clients to get fair access to the network. Ethereum, on the other hand, supports much larger callData | ||
| sizes.The 6KB limit is highly problematic for developer experience, and unexpectedly, for network efficiency. This |
There was a problem hiding this comment.
Missing space:
sizes.The ==> sizes. The
| The configured value for the size of an event in gossip should be set greater than one full-sized jumbo transaction. | ||
| The configured value for the size of an event in gossip should be set greater than one full-sized jumbo transaction | ||
| plus room for all the needed event meta data. If the max size of events prevent carrying at least 1 jumbo | ||
| transactions, then any node receiving a single max sized jumbo transaction have its transaction pool clogged and the |
There was a problem hiding this comment.
Missing a word?
Suggested change
| transactions, then any node receiving a single max sized jumbo transaction have its transaction pool clogged and the | |
| transactions, then any node receiving a single max sized jumbo transaction could have its transaction pool clogged and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the limits in smart contract creation to match Ethereum limits.