Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #62 resolved. #76

Merged
merged 12 commits into from
May 4, 2020
Merged

Issue #62 resolved. #76

merged 12 commits into from
May 4, 2020

Conversation

pranitb10
Copy link
Contributor

This contains the solution for Issue #62 i.e Implement Container and Bootstrap grid throughout the page. Also, I have removed the extra unnecessary inline properties.

@arps18 arps18 requested a review from Amorpheuz April 29, 2020 06:08
Copy link
Collaborator

@Amorpheuz Amorpheuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a need for multiple containers throughout the site, all the containers can be replaced by a single container containing all the rows. Also, the navbar shouldn't be part of a container. You might want to go through this and this for some more info!

@pranitb10
Copy link
Contributor Author

Sure @Amorpheuz . On it!

@arps18
Copy link
Collaborator

arps18 commented May 3, 2020

@Amorpheuz I've solved conflict in the file, so kindly review if any changes are to be done!

style/style.css Outdated
@@ -305,7 +328,7 @@ html{

.accordion-content {
padding: 0 20px;
margin-left: 100px;
margin-left: 40px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit things not related to your issue xD, they might be getting fixed in another issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, have set it back to as it was before.

@arps18 arps18 merged commit 8520ad6 into harshil1712:flame May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants