Home page with footer

[harshil1712]

Fixes #3 and #1
here is the output

Chrome

Firefox

[obitodarky]

I think we can use the styled button component in a different file. The header also uses that button and it's better to separate styled components for clean code.

[harshil1712]

@obitodarky I agree. I was planning to do that once we are ready with few pages. We tried the component first approach it only made us slow. We can do that once we have the MVP ready.

[obitodarky]

@harshil1712 if you can make a new component and also check if the styled button is clickable then I would like to merge this to master and then work on the header.

[obitodarky]

I tried to implement the styled button in my header. It appears fine but it isn't clickable for me. Have you checked if you can perform actions on this StyledButton?

[harshil1712]

Since I haven't added any on press methods nor linked to a different page, the button isn't working. But if we add a method or a link it will work

…

On Fri, 28 Jun, 2019, 11:54 AM Harsh Mehta, ***@***.***> wrote: ***@***.**** commented on this pull request. @harshil1712 <https://github.com/harshil1712> if you can make a new component and also check if the styled button is clickable then I would like to merge this to master and then work on the header. ------------------------------ In src/pages/index.js <#15 (comment)>: > + <div> + <Typography>We are Mozilla Gujarat!</Typography> + <Typography> + A highly enthusiastic community of Mozilla lovers in Gujarat, + India. + </Typography> + <Typography variant="inherit" style={{ fontFamily: "Zilla Slab" }}> + We{" "} + <span role="img" aria-label="heart emoji"> + &#x2764;&#xFE0F; + </span>{" "} + the Web! + </Typography> + </div> + </GridList> + <StyledButton> I tried to implement the styled button in my header. It appears fine but it isn't clickable for me. Have you checked if you can perform actions on this StyledButton? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15?email_source=notifications&email_token=AEQGQKECXF34U44GL6F4FDLP4WVBHA5CNFSM4H3XKDI2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4ZWCLI#pullrequestreview-255025453>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEQGQKHSTMOJ6DI7SPADCETP4WVBHANCNFSM4H3XKDIQ> .