Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes circular component sizing functionality for all devices. Fix #9 #13

Conversation

Amorpheuz
Copy link
Collaborator

Fixes sizing issues of #9

The circular component should scale properly on all devices now, Set it's width to be 40% of the screen.

In order to modify how the circle looks and it's positioning, modify SemiCircleContainer, while color of the semicircle can be modified via SemiCircle Component.

Preview:

  • Right Side
    image

  • Left Side
    image

@harshil1712
Copy link
Owner

This still doesn't fix the issue. I was setting the height more than 100% so that we could set its position (top) such that the we get the expected result. We don't want the whole semi circle. Compare your result with the design, focus more on the top and bottom, you will understand what I mean to say.

@Amorpheuz
Copy link
Collaborator Author

Yup, I noticed it later in the night, I have got another idea which I will hopefully get done with today... That one should work flawlessly

@harshil1712
Copy link
Owner

Did you solve the issue for left side?

@Amorpheuz
Copy link
Collaborator Author

Done with full circular component setup for desktop that is. Setup 3 different variations of the component, a left, right and one specific to home with more negative space.

Is this the confirmed mobile design?
image

If so, I can setup another top variation for the same. Do you recommend having media queries as outlined here for switching between top and desktop?

@harshil1712
Copy link
Owner

harshil1712 commented Jun 28, 2019 via email

@arps18 arps18 closed this Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants