[FFM-8840] - Remove Google Guava libraries, part #1 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What This PR will remove Google Guava from the SDK, including the following imports from every class file: import com.google.common.collect.Maps; import com.google.common.util.concurrent.AbstractScheduledService; import com.google.common.util.concurrent.AtomicLongMap; import com.google.common.util.concurrent.MoreExecutors; import com.google.common.util.concurrent.Service; import static com.google.common.io.Files.fileTraverser; import static com.google.common.util.concurrent.Service.State.*; import static com.google.common.util.concurrent.Service.State.RUNNING; Alternative implementations will be provided Why Guava has a large footprint of around ~2MB with no ability to only import the features we need. This can cause problems for certain environments where class size is limited (Lambda). It can also bring in a lot of unwanted dependencies into the customer's classpath. We aim to make the SDKs as slim and non-intrusive as possible. Testing Unit testing, testgrid and manual
andybharness
changed the title
akiraqb
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFM-8840 - Remove Google Guava libraries
What
part #1: Removes
AtomicLongMapandmapdbThis PR will remove Google Guava from the SDK, including the following imports from every class file:
Alternative implementations will be provided.
org.mapdb:mapdbwill also be removed since this bring in Guava as well. This is only used byFileMapStore.Why
Guava has a large footprint of around ~2MB with no ability to only import the features we need. This can cause problems for certain environments where class size is limited (Lambda). It can also bring in a lot of unwanted dependencies into the customer's classpath. We aim to make the SDKs as slim and non-intrusive as possible.
Testing
Unit testing, testgrid and manual