Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FFM-8148] - Standardise SDK error codes #158

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

andybharness
Copy link
Contributor

@andybharness andybharness commented Aug 14, 2023

FFM-8148 - Standardise SDK error codes

What
Adding standardised SDK error codes + pushing some logs down to debug to reduce noise

Why
Each SDK uses different log messages for its lifecycle. We want to standardise messages across SDKs with a unique code.

Testing
Manual testing + unit testing

What
Adding standardised SDK error codes + pushing some logs down to debug to reduce noise

Why
Each SDK uses different log messages for its lifecycle. We want to standardise messages across SDKs with a unique code.

Testing
Manual testing + unit testing
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.26% and project coverage change: +0.28% 🎉

Comparison is base (14d3516) 60.98% compared to head (c9a2e25) 61.27%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #158      +/-   ##
============================================
+ Coverage     60.98%   61.27%   +0.28%     
- Complexity      364      385      +21     
============================================
  Files            31       32       +1     
  Lines          1779     1836      +57     
  Branches        202      211       +9     
============================================
+ Hits           1085     1125      +40     
- Misses          541      550       +9     
- Partials        153      161       +8     
Files Changed Coverage Δ
...io/harness/cf/client/connector/LocalConnector.java 0.00% <0.00%> (ø)
...va/io/harness/cf/client/connector/EventSource.java 70.83% <66.66%> (+0.20%) ⬆️
...ain/java/io/harness/cf/client/common/SdkCodes.java 73.33% <73.33%> (ø)
...ava/io/harness/cf/client/api/MetricsProcessor.java 79.19% <75.00%> (-1.22%) ⬇️
...ain/java/io/harness/cf/client/api/AuthService.java 77.77% <100.00%> (+0.85%) ⬆️
.../main/java/io/harness/cf/client/api/Evaluator.java 85.60% <100.00%> (+0.59%) ⬆️
...ain/java/io/harness/cf/client/api/InnerClient.java 70.23% <100.00%> (-1.66%) ⬇️
...ava/io/harness/cf/client/api/PollingProcessor.java 81.69% <100.00%> (ø)
.../harness/cf/client/connector/HarnessConnector.java 69.95% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andybharness andybharness merged commit 20a2f6e into main Aug 14, 2023
4 checks passed
@andybharness andybharness deleted the FFM-8148-sdk-codes branch August 14, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants