MEDIUM: runtime: Add glitch metrics to stick table fields

haproxytech · Jan 27, 2025 · 6780ea6 · 6780ea6
1 parent b286485
commit 6780ea6
Show file tree

Hide file tree

Showing 8 changed files with 63 additions and 5 deletions.
diff --git a/models/stick_table.go b/models/stick_table.go
diff --git a/models/stick_table_entry.go b/models/stick_table_entry.go
diff --git a/models/stick_table_entry_compare.go b/models/stick_table_entry_compare.go
diff --git a/models/stick_table_entry_compare_test.go b/models/stick_table_entry_compare_test.go
diff --git a/runtime/stick_tables.go b/runtime/stick_tables.go
@@ -238,6 +238,16 @@ func parseStickTableEntry(output string) *models.StickTableEntry { //nolint:goco
 			if err == nil {
 				entry.BytesOutRate = &bytesOutRate
 			}
+		case key == "glitch_cnt":
+			glitchCnt, err := strconv.ParseInt(strings.TrimSpace(v), 10, 64)
+			if err == nil {
+				entry.GlitchCnt = &glitchCnt
+			}
+		case strings.HasPrefix(key, "glitch_rate("):
+			glitchRate, err := strconv.ParseInt(strings.TrimSpace(v), 10, 64)
+			if err == nil {
+				entry.GlitchRate = &glitchRate
+			}
 		case key == "use":
 			entry.Use = strings.TrimSpace(v) == "1"
 		case key == "exp":

diff --git a/specification/build/haproxy_spec.yaml b/specification/build/haproxy_spec.yaml
@@ -9447,6 +9447,8 @@ definitions:
                 - server_id
                 - sess_cnt
                 - sess_rate
+                - glitch_rate
+                - glitch_cnt
               type: string
             period:
               type: integer
@@ -9513,6 +9515,12 @@ definitions:
       exp:
         type: integer
         x-nullable: true
+      glitch_cnt:
+        type: integer
+        x-nullable: true
+      glitch_rate:
+        type: integer
+        x-nullable: true
       gpc0:
         type: integer
         x-nullable: true

diff --git a/specification/models/runtime/table.yaml b/specification/models/runtime/table.yaml
@@ -44,6 +44,8 @@ table:
               - server_id
               - sess_cnt
               - sess_rate
+              - glitch_rate
+              - glitch_cnt
           type:
             type: string
             enum: [rate, counter]

diff --git a/specification/models/runtime/table_entry.yaml b/specification/models/runtime/table_entry.yaml
@@ -70,3 +70,9 @@ table_entry:
       x-nullable: true
     use:
       type: boolean
+    glitch_cnt:
+      type: integer
+      x-nullable: true
+    glitch_rate:
+      type: integer
+      x-nullable: true