Dowgrade glob v11 to v10 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only change listed in the v11 changelog is dropping support for node before v20. We want to support node v18 right now, so I am downgrading this back to v10. https://github.com/isaacs/node-glob/blob/main/changelog.md#110
lencioni
commented
Feb 17, 2025
| @@ -3272,7 +3272,7 @@ glob@^10.0.0: | |||
| package-json-from-dist "^1.0.0" | |||
| path-scurry "^1.11.1" | |||
|
|
|||
| glob@^11.0.0, glob@^11.0.1: | |||
| glob@^11.0.0: | |||
There was a problem hiding this comment.
v11 comes in as a transitive dep of rimraf, which is just a dev dep here, so we don't need to worry about this.
lencioni
added a commit
that referenced
this pull request
Feb 17, 2025
We recently updated glob to v11, which does not support Node 18, and so have to downgrade it and publish another release: #330 I want to make sure we catch this in CI next time and I think this might do the trick.
lencioni
added a commit
that referenced
this pull request
Feb 17, 2025
We recently updated glob to v11, which does not support Node 18, and so have to downgrade it and publish another release: #330 I want to make sure we catch this in CI next time and I think this might do the trick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change listed in the v11 changelog is dropping support for node before v20. We want to support node v18 right now, so I am downgrading this back to v10.
https://github.com/isaacs/node-glob/blob/main/changelog.md#110