Use zlib level 6 when making zip files #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that by default Archiver uses zlib level 1, which prioritizes compression speed over compression ratio. By default, zlib uses level 6, which is a nice balance between compression speed and compression ratio. In my testing, level 6 does indeed seem to be a sweet spot, and seems to make my test cases about 14% smaller without sacrificing much performance. Since these zips are immediately uploaded, stored, and downloaded again somewhere else, I am hopeful that this 14% size difference will more than make up for slightly slower compression speeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that by default Archiver uses zlib level 1, which prioritizes compression speed over compression ratio. By default, zlib uses level 6, which is a nice balance between compression speed and compression ratio. In my testing, level 6 does indeed seem to be a sweet spot, and seems to make my test cases about 14% smaller without sacrificing much performance.
Since these zips are immediately uploaded, stored, and downloaded again somewhere else, I am hopeful that this 14% size difference will more than make up for slightly slower compression speeds.