More logging #285
Merged
More logging #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help debugging certain issues.
This commit serves two purposes: One is to output the version of the CLI in the happo-ci logs. The other purpose is to catch a misconfigured HAPPO_COMMAND. By attempting to get the version, we can catch errors and output a helpful message instead of failing with a cryptic message of this kind: 2024-06-24T21:04:09.6031947Z /some/absolute/path/node_modules/.bin/happo-ci: line 104: node_modules/happo.io/build/cli.js: No such file or directory
lencioni
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some logs to the happo-ci script, to help with debugging.