Add node 20 and 22 to test matrix, use node v20.14.0 locally #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us ensure that this package works well on these versions of node.
This is the latest Node LTS version.
When running on Node 18 and older, this error message contains the "connect ECONNREFUSED" string. But on Node 20+, it does not. This causes the test to fail: > Expected pattern: /connect ECONNREFUSED/ > Received message: "request to http://localhost:8990/success failed, > reason: (took 1 ms)" https://github.com/happo/happo.io/actions/runs/9571942826/job/26390148668?pr=276
|
if you want your test matrix to be automatically maintained as new node versions come out, consider ljharb/actions/node/install :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required adjusting an assertion on an error message a bit.