Don't skip interactive screenshots for first item #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the first story in the list of stories in the whole storybook had a play function together with forceHappoScreenshot, we wouldn't include these screenshots in the report. This was because the check to see if we were currently running Happo was checking for `currentIndex`. This variable starts as `0`/falsy. To fix this, I'm instead checking to see if the normal init process has produced any examples. If not, we know we're not running Happo. The bug that would materialize from this would be that the first story would only have one screenshot. The ones produced via forceHappoScreenshot inside the play function would be ignored. This problem would also be present multiple times if you were using `chunks` config in .happo.js. Every interactive story at the start of each chunk would also have missing screenshots.
|
The storybook 7 build was stuck on yarn install. I'm going to merge anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first story in the list of stories in the whole storybook had a play function together with forceHappoScreenshot, we wouldn't include these screenshots in the report. This was because the check to see if we were currently running Happo was checking for
currentIndex. This variable starts as0/falsy. To fix this, I'm instead checking to see if the normal init process has produced any examples. If not, we know we're not running Happo.The bug that would materialize from this would be that the first story would only have one screenshot. The ones produced via forceHappoScreenshot inside the play function would be ignored. This problem would also be present multiple times if you were using
chunksconfig in .happo.js. Every interactive story at the start of each chunk would also have missing screenshots.