Prevent infinite loop when error is thrown during play invocation
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the play function throws an error, we didn't properly disambiguate it from the internal error thrown by `forceHappoScreenshot`. This caused the test suite to re-render the last step over and over (until eventually the browser crashed). To fix this, I'm adding a `done` boolean to the step created by forceHappoScreenshot. Each step is only allowed to be processed once. It's a little annoying that the `errored` event details do not contain any information about the thrown error. If it did, we wouldn't have to do this complicated detection to see if the error is ours or someone elses.
This should help fix the following issue:
Error: Unable to perform pointer interaction as the element has `pointer-events: none`:
BUTTON(label=click me)
at assertPointerEvents (http://localhost:4433/784.fc9cd2d3.iframe.bundle.js:1:965181)
at Object.enter (http://localhost:4433/784.fc9cd2d3.iframe.bundle.js:1:968154)
at Object.move (http://localhost:4433/784.fc9cd2d3.iframe.bundle.js:1:973957)
at pointerAction (http://localhost:4433/784.fc9cd2d3.iframe.bundle.js:1:985358)
at Object.pointer (http://localhost:4433/784.fc9cd2d3.iframe.bundle.js:1:992810)
Before, I was only letting the report get created, without comparing the results with a previous version. This was limiting and I often found myself having to manually compare with the previous state.
I couldn't get yarn to execute the bash script that happo-ci-github-actions is. Going to try wrapping it in a scripts entry to ensure bash is used.
This will ensure that I can run happo-ci-github-actions in CI.
I'm trying to figure out if there's a discrepancy between the local version and the CI version.
This is the version we use locally. Hoping it will make errors less confusing.
Hoping this will fix the shebang issue.
--frozen-lockfile is deprecated
This will make the lockfile up-to-date with what CI will expect.
Hoping this could help.
I'm hoping this will help resolve the following error:
/home/runner/work/happo-plugin-storybook/happo-plugin-storybook/node_modules/happo.io/bin/happo-ci:3
^
SyntaxError: Invalid or unexpected token
at internalCompileFunction (node:internal/vm:73:18)
at wrapSafe (node:internal/modules/cjs/loader:1274:20)
at Module._compile (node:internal/modules/cjs/loader:1320:27)
at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)
at Module.load (node:internal/modules/cjs/loader:1197:32)
at Module._load (node:internal/modules/cjs/loader:1013:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
at node:internal/main/run_main_module:28:49
I'm running into so many issues right now that I'm trying to switch back to classic yarn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the play function throws an error, we didn't properly disambiguate it from the internal error thrown by
forceHappoScreenshot. This caused the test suite to re-render the last step over and over (until eventually the browser crashed). To fix this, I'm adding adoneboolean to the step created by forceHappoScreenshot. Each step is only allowed to be processed once.It's a little annoying that the
erroredevent details do not contain any information about the thrown error. If it did, we wouldn't have to do this complicated detection to see if the error is ours or someone elses.